Skip to content

Fix panic when mtls is disabled #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

Fix panic when mtls is disabled #749

merged 1 commit into from
Jun 10, 2025

Conversation

@JanHolger
Copy link
Contributor

@JanHolger JanHolger commented Jun 4, 2025

When mTLS is disabled (no --server-ca-cert) previously the server panic'ed due to an index error when trying to access the first peer certificate since go does not even parse client certificates in this case. As this was only accessed for logging the common name of the client, I've added a second check to check if there is a peer certificate present to the existing check that already checked if tls is enabled.

@k8s-ci-robot k8s-ci-robot requested review from elmiko and ipochi June 4, 2025 17:23
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2025

Welcome @JanHolger!

It looks like this is your first PR to kubernetes-sigs/apiserver-network-proxy 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/apiserver-network-proxy has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 4, 2025

Hi @JanHolger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2025
@jkh52
Copy link
Contributor

jkh52 commented Jun 4, 2025

/ok-to-test

Looks like a very old bug, thank you for fixing!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@jkh52
Copy link
Contributor

jkh52 commented Jun 10, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanHolger, jkh52

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit e135055 into kubernetes-sigs:master Jun 10, 2025
22 checks passed
ipochi pushed a commit to kinvolk/apiserver-network-proxy that referenced this pull request Aug 21, 2025
@k8s-ci-robot @ipochi
Merge pull request kubernetes-sigs#749 from JanHolger/fix-panic-witho…
a2cdfb4 
…ut-mtls

Fix panic when mtls is disabled

(cherry picked from commit e135055)
ipochi pushed a commit to kinvolk/apiserver-network-proxy that referenced this pull request Aug 21, 2025
@k8s-ci-robot @ipochi
Merge pull request kubernetes-sigs#749 from JanHolger/fix-panic-witho…
d59e430 
…ut-mtls

Fix panic when mtls is disabled

(cherry picked from commit e135055)
ipochi pushed a commit to kinvolk/apiserver-network-proxy that referenced this pull request Aug 21, 2025
@k8s-ci-robot @ipochi
Merge pull request kubernetes-sigs#749 from JanHolger/fix-panic-witho…
b633b81 
…ut-mtls

Fix panic when mtls is disabled

(cherry picked from commit e135055)
This was referenced Aug 21, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@ipochi ipochi Awaiting requested review from ipochi

Assignees

@jkh52 jkh52

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JanHolger @k8s-ci-robot @jkh52